Skip to content

feat(chat): fold agent chatter and promote human notes - #174

Open
nullStack65 wants to merge 4 commits into
release/native-0.1.10from
feat/ux-bot-collapse-and-note-promote
Open

nullStack65 wants to merge 4 commits into
release/native-0.1.10from
feat/ux-bot-collapse-and-note-promote

Conversation

@nullStack65

@nullStack65 nullStack65 commented Nov 22, 2026 •

Copy link
Copy Markdown
Owner

Agent-to-agent updates can bury the conversation in busy threads. Chat now groups consecutive bot activity under a live summary and opens the fold when new attention is needed. Human prompts, their replies, founder-addressed messages, and /note entries stay in the timeline.

Web, desktop, and native Chat show a Model-hidden note label. Promote to agent queues the original note text as a separate user message and gives success or retry feedback. The note capability gate and founder attribution have their own work in #171 and #173.

Tracking issue T3 Chat activity and note promotion.

Verification

  • Web, mobile, and client-runtime typechecks passed.
  • Web timeline unit tests passed (135). Native pending-feed unit tests passed (11).
  • Chromium coverage passed for note visibility, opening the chatter fold, promotion with original text, and retry after failure. The existing send_to_user citation test timed out on both the release base and this branch.
  • The release-scoped changed check surfaced existing timeline lint and repository Knip findings. Native device verification requires Agent Device access, which is disabled in this environment.

Prior art

  • Extend the existing timeline fold controls. They preserve the virtual list's scroll position and the original receipt rows.
  • Reuse the guarded start-turn command for promotion. Both clients can send the original text and leave the source note in place.
  • Share run classification and counts in client-runtime. Each client retains its existing row and disclosure components.

Model codex/gpt-6.2-sol via Codex in T3 Code.

Deploy: none

Model: codex/gpt-6.2-sol
Task: CLO-1121
Agent: Codex
Lane: codex
Model: codex/gpt-6.2-sol
Task: CLO-1121
Agent: Codex
Lane: codex
Model: codex/gpt-6.2-sol
Task: CLO-1121
Agent: Codex
Lane: codex
@coderabbitai

coderabbitai Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@nullStack65

Copy link
Copy Markdown
Owner Author

FINDING

Single independent review of d33c2e08d2109e47725e5ee18f87c20f1b979a16 on release base 18cf8f27f1df245acf78bbbbbea34c1475f4585a. Hold for note privacy, founder decision visibility, and idempotent promotion. The reviewer verified 150 focused cases and three typechecks. The citation timeout and the two lint findings reproduce on the base. The pinned ARC workflow runs different checks, and no ARC waiver is implied. Native display and source attribution should be corrected with the in-scope fixes. Real Electron and live native acceptance remain open.

{"reviewed_head":"d33c2e08d2109e47725e5ee18f87c20f1b979a16","reviewer":"GPT-6.2 Sol via Codex · Magpie (independent T3 delegate)","findings":[{"id":"F1","severity":"critical","summary":"Human notes are available to an agent before explicit promotion, contrary to the privacy shown in the UI.","outcome":"open"},{"id":"F2","severity":"important","summary":"An intervening reply can leave the pending founder decision collapsed.","outcome":"open"},{"id":"F3","severity":"important","summary":"Remounting or switching clients can submit a second promotion for one note.","outcome":"open"},{"id":"F4","severity":"nit","summary":"Native note headings, promotion source, and settled counts regress.","outcome":"open"},{"id":"F5","severity":"nit","summary":"The candidate adds an unused isDecisionRequestItem export.","outcome":"open"}]}

Repair the five published Chat UX findings tracked in CLO-1121. Persist note promotion with the queued send, prefer the originating decision run, and keep native sender and settlement details visible.

Model: codex/gpt-6.2-sol
Task: fix
Agent: Magpie
Lane: magpie
Harness: t3/codex
@nullStack65

Copy link
Copy Markdown
Owner Author

CHECKPOINT

Focused recheck of the single review on repair head db3a4ba993bc6f9e83883f59827ba75935217115, reviewed parent d33c2e08d2109e47725e5ee18f87c20f1b979a16, unchanged release base 18cf8f27f1df245acf78bbbbbea34c1475f4585a. F2–F5 passed targeted verification. F1 remains open after an additional synthetic boundary check and continues to block merge. The focused run passed 277 cases. The decision fallback still applies when the originating request is absent from the available timeline. Desktop and live native evidence remain open.

{"reviewed_head":"d33c2e08d2109e47725e5ee18f87c20f1b979a16","reviewer":"GPT-6.2 Sol via Codex · Magpie (original independent T3 review; focused repair verification)","findings":[{"id":"F1","severity":"critical","summary":"The pre-promotion privacy contract remains incomplete in a model-facing generation path.","outcome":"open"},{"id":"F2","severity":"important","summary":"An intervening reply can leave the pending founder decision collapsed.","outcome":"confirmed","rechecked_head":"db3a4ba993bc6f9e83883f59827ba75935217115"},{"id":"F3","severity":"important","summary":"Remounting or switching clients can submit a second promotion for one note.","outcome":"confirmed","rechecked_head":"db3a4ba993bc6f9e83883f59827ba75935217115"},{"id":"F4","severity":"nit","summary":"Native note headings, promotion source, and settled counts regress.","outcome":"fixed"},{"id":"F5","severity":"nit","summary":"The candidate adds an unused isDecisionRequestItem export.","outcome":"fixed"}]}

@nullStack65

Copy link
Copy Markdown
Owner Author

Frozen 2026-11-22 CEO portfolio audit — cash-path priority; can reopen at the Dec 18 runway check.

@nullStack65 nullStack65 reopened this Nov 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant